Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux aarch64 wheel build support #30

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jun 21, 2021

Added linux aarch64 wheel build support.
Related to #29. @zhuyifei1999, could you please review this PR?

@zhuyifei1999
Copy link
Owner

Is dist: focal required?

Should I test if cibuildwheel works as expected on aarch64? Otherwise I could let it run as part of next release (I'm planning to do it when I fix #27, or when Python 3.10 comes out, whichever comes earlier, but if you want I can release immediately).

@odidev
Copy link
Contributor Author

odidev commented Jun 24, 2021

Is dist: focal required?

dist: focal is not mandatory, we can remove it, by default it will be Xenial. Please let me know if you want me to remove it.

Should I test if cibuildwheel works as expected on aarch64? Otherwise I could let it run as part of next release (I'm planning to do it when I fix #27, or when Python 3.10 comes out, whichever comes earlier, but if you want I can release immediately).

If I am understanding, your concern is that whether cibuildwheel supports aarch64 or not. If yes, then there is no need to test it, cibuildwheel is supported for aarch64.
Please let me know if you have any other concerns.
It would be really helpful if you release the wheels in your next release.

@zhuyifei1999
Copy link
Owner

dist: focal is not mandatory, we can remove it, by default it will be Xenial. Please let me know if you want me to remove it.

cibuildwheel:

As I understand, cibuildwheel starts a docker container, which will have a full root filesystem inside, right? Therefore, the choice of the distro version should not matter, as long as they support docker, right?

If that is the case, I prefer to have the least amount of time-dependent configs as possible, since I would then be responsible for updating them when it fails to work one day when focal is EOL.

test builds:

I would prefer default xenial, one to keep consistent with x86_64 test builds, two, similar to cibuildwheel, for less maintenance.

Do you want me to release immediately after merge?

@odidev
Copy link
Contributor Author

odidev commented Jun 29, 2021

dist: focal is not mandatory, we can remove it, by default it will be Xenial. Please let me know if you want me to remove it.

cibuildwheel:

As I understand, cibuildwheel starts a docker container, which will have a full root filesystem inside, right? Therefore, the choice of the distro version should not matter, as long as they support docker, right?

If that is the case, I prefer to have the least amount of time-dependent configs as possible, since I would then be responsible for updating them when it fails to work one day when focal is EOL.

test builds:

I would prefer default xenial, one to keep consistent with x86_64 test builds, two, similar to cibuildwheel, for less maintenance.

Do you want me to release immediately after merge?

I have removed focal distro as discussed and it would be really helpful if you can release it after the merge.

@zhuyifei1999 zhuyifei1999 merged commit 2a56af1 into zhuyifei1999:master Jun 29, 2021
@zhuyifei1999
Copy link
Owner

ok I'll do a release rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants